Added env based support for HTTPS connection #4706

Saranya-jena · 2024-06-13T16:28:46Z

Proposed changes

Enhanced auth and the graphql server to support both http and https and allow users to leverage either option using env.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

New feature (non-breaking change which adds functionality)
Bugfix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

I have read the CONTRIBUTING doc
I have signed the commit for DCO to be passed.
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

ispeakc0de · 2024-06-14T06:50:57Z

chaoscenter/authentication/api/main.go

+		if utils.CustomTlsCert != "" && utils.TlSKey != "" {
+			go runGrpcServerWithTLS(applicationService)
+		} else {
+			log.Fatalf("Failure to start chaoscenter authentication REST server due to empty TLS cert file path and TLS key path")


Suggested change

log.Fatalf("Failure to start chaoscenter authentication REST server due to empty TLS cert file path and TLS key path")

log.Fatalf("Failure to start chaoscenter authentication GRPC server due to empty TLS cert file path and TLS key path")

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

…tmus into encryption-fixes

Jonsy13 · 2024-06-21T06:06:33Z

chaoscenter/authentication/api/main.go

+	}
+
+	if enableHTTPSConnection {
+		if utils.CustomTlsCert != "" && utils.TlSKey != "" {


We can rename it wrt paths

namkyu1999

can you check build-pipeline / backend-checks (pull_request) ?

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

…tmus into encryption-fixes

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

Jonsy13 · 2024-06-24T05:49:50Z

chaoscenter/authentication/api/main.go

+	log.Infof("Listening and serving gRPC on %s with TLS", utils.GrpcPort)
+	err = grpcServer.Serve(lis)
+	if err != nil {
+		log.Fatalf("Failure to start litmus-portal authentication GRPC server due to %v", err)


Suggested change

log.Fatalf("Failure to start litmus-portal authentication GRPC server due to %v", err)

log.Fatalf("Failure to start chaos-center authentication GRPC server due to %v", err)

Jonsy13 · 2024-06-24T05:50:34Z

chaoscenter/authentication/api/main.go

+		log.Fatalf("Failure to start litmus-portal authentication server due to %s", err)
+	}
+
+	// configuration of the certificate what we want


Suggested change

// configuration of the certificate what we want

// configuring TLS config based on provided certificates & keys

Jonsy13 · 2024-06-24T05:50:47Z

chaoscenter/graphql/server/pkg/authorization/validate.go

@@ -20,6 +21,7 @@ func ValidateRole(ctx context.Context, projectID string,
 		requiredRoles,
 		invitation)
 	if err != nil {
+		fmt.Println("errrrrrrrrrrrr ", err)


This can be removed or print it with logrus and make it error level?

Jonsy13 · 2024-06-24T05:53:06Z

chaoscenter/graphql/server/server.go

 	go startGRPCServer(utils.Config.RpcPort, mongodbOperator) // start GRPC serve
+	if enableHTTPSConnection {
+		if utils.Config.ServerTlsCertPath != "" && utils.Config.ServerTlsKeyPath != "" {
+			go startGRPCServerWithTLS("8001", mongodbOperator) // start GRPC serve


Port is hardcoded

Jonsy13 · 2024-06-24T05:54:43Z

chaoscenter/graphql/server/server.go

+		}
+	}()
+	if enableHTTPSConnection {
+		// configuration of the certificate what we want


do we need log here as well same as above

log.Infof("graphql server running at https://localhost:%s", utils.Config.HttpsPort)

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

…tmus into encryption-fixes

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

…tmus into encryption-fixes

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

…ncryption-fixes

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* Added env based support for HTTPS connection Signed-off-by: Saranya-jena <saranya.jena@harness.io> * resolved review comments Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated logic Signed-off-by: Saranya-jena <saranya.jena@harness.io> * fixed importd Signed-off-by: Saranya-jena <saranya.jena@harness.io> * added helper files Signed-off-by: Saranya-jena <saranya.jena@harness.io> * resolved comments Signed-off-by: Saranya-jena <saranya.jena@harness.io> * resolved comments Signed-off-by: Saranya-jena <saranya.jena@harness.io> * Update push.yml * minor changes Signed-off-by: Saranya-jena <saranya.jena@harness.io> * minor changes Signed-off-by: Saranya-jena <saranya.jena@harness.io> * minor changes Signed-off-by: Saranya-jena <saranya.jena@harness.io> * minor changes Signed-off-by: Saranya-jena <saranya.jena@harness.io> * minor changes Signed-off-by: Saranya-jena <saranya.jena@harness.io> * Update push.yml * updated oush.yam Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated manifest Signed-off-by: Saranya-jena <saranya.jena@harness.io> --------- Signed-off-by: Saranya-jena <saranya.jena@harness.io> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>

* Added env based support for HTTPS connection Signed-off-by: Saranya-jena <saranya.jena@harness.io> * resolved review comments Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated logic Signed-off-by: Saranya-jena <saranya.jena@harness.io> * fixed importd Signed-off-by: Saranya-jena <saranya.jena@harness.io> * added helper files Signed-off-by: Saranya-jena <saranya.jena@harness.io> * resolved comments Signed-off-by: Saranya-jena <saranya.jena@harness.io> * resolved comments Signed-off-by: Saranya-jena <saranya.jena@harness.io> * Update push.yml * minor changes Signed-off-by: Saranya-jena <saranya.jena@harness.io> * minor changes Signed-off-by: Saranya-jena <saranya.jena@harness.io> * minor changes Signed-off-by: Saranya-jena <saranya.jena@harness.io> * minor changes Signed-off-by: Saranya-jena <saranya.jena@harness.io> * minor changes Signed-off-by: Saranya-jena <saranya.jena@harness.io> * Update push.yml * updated oush.yam Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated manifest Signed-off-by: Saranya-jena <saranya.jena@harness.io> --------- Signed-off-by: Saranya-jena <saranya.jena@harness.io> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com> Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>

Added env based support for HTTPS connection

0a19e54

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

Saranya-jena requested review from ispeakc0de, Jonsy13, gdsoumya, SarthakJain26 and namkyu1999 June 13, 2024 16:28

Saranya-jena self-assigned this Jun 13, 2024

Merge branch 'master' into encryption-fixes

76345b2

ispeakc0de reviewed Jun 14, 2024

View reviewed changes

ispeakc0de approved these changes Jun 14, 2024

View reviewed changes

Saranya-jena added 2 commits June 21, 2024 10:47

resolved review comments

330ec52

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

Merge branch 'encryption-fixes' of https://github.com/Saranya-jena/li…

336665c

…tmus into encryption-fixes

Saranya-jena marked this pull request as ready for review June 21, 2024 05:17

SarthakJain26 approved these changes Jun 21, 2024

View reviewed changes

Jonsy13 reviewed Jun 21, 2024

View reviewed changes

Merge branch 'master' into encryption-fixes

149c387

namkyu1999 approved these changes Jun 24, 2024

View reviewed changes

Saranya-jena added 3 commits June 24, 2024 10:55

updated logic

a9736c7

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

Merge branch 'encryption-fixes' of https://github.com/Saranya-jena/li…

1d6eb99

…tmus into encryption-fixes

fixed importd

710cb04

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

Jonsy13 reviewed Jun 24, 2024

View reviewed changes

Saranya-jena added 5 commits June 24, 2024 11:53

added helper files

f999601

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

resolved comments

13ec01c

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

resolved comments

e9f6c01

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

Update push.yml

f32a433

minor changes

12acd13

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

Saranya-jena added 12 commits July 2, 2024 16:39

Merge branch 'encryption-fixes' of https://github.com/Saranya-jena/li…

2979e72

…tmus into encryption-fixes

minor changes

708c787

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

minor changes

187a959

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

minor changes

9eadda5

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

minor changes

70b280c

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

Update push.yml

14796a4

updated branch

53228c0

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

Merge branch 'encryption-fixes' of https://github.com/Saranya-jena/li…

cc8f811

…tmus into encryption-fixes

updated branch

0cedfc6

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

updated oush.yam

f479270

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

Merge branch 'master' of https://github.com/litmuschaos/litmus into e…

2240e1e

…ncryption-fixes

updated manifest

427c364

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

Jonsy13 approved these changes Jul 8, 2024

View reviewed changes

Saranya-jena merged commit 9f4fe25 into litmuschaos:master Jul 8, 2024
18 of 19 checks passed

Saranya-jena mentioned this pull request Jul 11, 2024

Fixed issues with go routines #4754

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added env based support for HTTPS connection #4706

Added env based support for HTTPS connection #4706

Saranya-jena commented Jun 13, 2024 •

edited

Loading

ispeakc0de Jun 14, 2024

Jonsy13 Jun 21, 2024

namkyu1999 left a comment

Jonsy13 Jun 24, 2024

Jonsy13 Jun 24, 2024

Jonsy13 Jun 24, 2024 •

edited

Loading

Jonsy13 Jun 24, 2024

Jonsy13 Jun 24, 2024

	log.Fatalf("Failure to start chaoscenter authentication REST server due to empty TLS cert file path and TLS key path")
	log.Fatalf("Failure to start chaoscenter authentication GRPC server due to empty TLS cert file path and TLS key path")

	log.Fatalf("Failure to start litmus-portal authentication GRPC server due to %v", err)
	log.Fatalf("Failure to start chaos-center authentication GRPC server due to %v", err)

	// configuration of the certificate what we want
	// configuring TLS config based on provided certificates & keys

Added env based support for HTTPS connection #4706

Added env based support for HTTPS connection #4706

Conversation

Saranya-jena commented Jun 13, 2024 • edited Loading

Proposed changes

Types of changes

Checklist

Dependency

Special notes for your reviewer:

ispeakc0de Jun 14, 2024

Choose a reason for hiding this comment

Jonsy13 Jun 21, 2024

Choose a reason for hiding this comment

namkyu1999 left a comment

Choose a reason for hiding this comment

Jonsy13 Jun 24, 2024

Choose a reason for hiding this comment

Jonsy13 Jun 24, 2024

Choose a reason for hiding this comment

Jonsy13 Jun 24, 2024 • edited Loading

Choose a reason for hiding this comment

Jonsy13 Jun 24, 2024

Choose a reason for hiding this comment

Jonsy13 Jun 24, 2024

Choose a reason for hiding this comment

Saranya-jena commented Jun 13, 2024 •

edited

Loading

Jonsy13 Jun 24, 2024 •

edited

Loading